Skip to content

build: update dependency @web/test-runner-core to v1 #3838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
angular-robot wants to merge 1 commit into
base: main
Choose a base branch
from
+86 −3
Open

build: update dependency @web/test-runner-core to v1 #3838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bazel/rules/rules_browsers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@types/node": "^22.14.0",
"@web/dev-server-rollup": "^0.6.4",
"@web/test-runner": "^0.20.2",
"@web/test-runner-core": "^0.13.4",
"@web/test-runner-core": "^1.0.0",
Comment on lines 24 to +25

@gemini-code-assist gemini-code-assist Bot Jul 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading @web/test-runner-core to ^1.0.0 while keeping @web/test-runner at ^0.20.2 introduces a version mismatch.

In pnpm-lock.yaml, @web/test-runner@0.20.2 and @web/test-runner-puppeteer@0.18.0 still resolve to and depend on @web/test-runner-core@0.13.4. However, the direct dependency on @web/test-runner-core is now resolved to 1.0.0.

This is highly problematic because wtr.config.mjs reads session.js directly from node_modules/@web/test-runner-core/browser/session.js (which will resolve to version 1.0.0), whereas the test runner itself will execute using version 0.13.4. This mismatch can lead to runtime errors or unexpected behavior.

Please upgrade @web/test-runner and its associated plugins (like @web/test-runner-puppeteer) to versions that are compatible with @web/test-runner-core ^1.0.0 to ensure a single, unified version of the core runner is used.

"@web/test-runner-puppeteer": "^0.18.0",
"get-port": "^7.1.0",
"jasmine": "^6.0.0",
Expand Down
87 changes: 85 additions & 2 deletions bazel/rules/rules_browsers/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.