feat(aria/spinbutton): add aria spinbutton component #32663
Draft
+2,599
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
OmerGronich
force-pushed
the
ng-aria-spin-button
branch
from
8f419d2 to
19a53fd
Compare
OmerGronich
force-pushed
the
ng-aria-spin-button
branch
from
19a53fd to
c7401c8
Compare
Adds a new `ngSpinButton` primitive for the ARIA spinbutton pattern following the W3C APG specification. The component provides keyboard navigation (Arrow keys, Page Up/Down, Home/End), value constraints (min/max/step), wrapping mode, and accessible auto-repeat on stepper buttons. Includes: - SpinButtonPattern and SpinButtonStepperPattern in private API - SpinButton, SpinButtonInput, SpinButtonGroup, SpinButtonIncrement, and SpinButtonDecrement directives - Example implementations including APG quantity picker and time field - Dev app demo page
OmerGronich
force-pushed
the
ng-aria-spin-button
branch
from
c7401c8 to
c00c21c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the ARIA spinbutton pattern based on WAI-ARIA guidelines.
WAI-ARIA Pattern Reference:
https://www.w3.org/WAI/ARIA/apg/patterns/spinbutton/
Completed:
ngSpinButton,ngSpinButtonIncrement,ngSpinButtonDecrement,ngSpinButtonGrouparia-valuenow,aria-valuetext,aria-valuemin,aria-valuemax,aria-disabled,aria-readonly,aria-invalid,aria-requiredaria-valuenowwhen value is undefined)Future Enhancements: