refactor(@angular/cli): use serveStdio to support both 2025 and 2026-07-28 MCP protocol eras - #33750
Merged
Merged
Conversation
…6-07-28 MCP protocol eras Replace direct `StdioServerTransport` connection in `cli.ts` with `serveStdio` from `@modelcontextprotocol/server/stdio`. `serveStdio` supports both the 2025-era protocol (`initialize` handshake) and the 2026-07-28 protocol revision over stdio on the same endpoint, automatically negotiating the era for each connection.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Angular CLI MCP command to use the serveStdio helper function from @modelcontextprotocol/server/stdio instead of manually instantiating StdioServerTransport and connecting the server. A critical issue was identified where the asynchronous serveStdio call is not being awaited, which can cause the command execution to terminate prematurely and lead to unhandled promise rejections.
clydin
added
the
action: review
alan-agius4
approved these changes
Aug 5, 2026
alan-agius4
added
action: merge
Collaborator
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace direct
StdioServerTransportconnection incli.tswithserveStdiofrom@modelcontextprotocol/server/stdio.serveStdiosupports both the 2025-era protocol (initializehandshake) and the 2026-07-28 protocol revision over stdio on the same endpoint, automatically negotiating the era for each connection.