Remove model from b-parasite#4482
Conversation
|
Hi, the model is a mandatory field. I've not ever had a need for a manufacturer only match so you'll have to duplicate them for each model. |
|
I did not modify anything from the upstream code, so I think we should go with b-paraside for now I could not find plan sensor at all in the code https://github.com/search?q=repo%3Arbaron%2Fb-parasite%20%22Plant%20sensor%22&type=code , so that may be a user customization. |
The b-parasite is an open hardware device and the default model is b-parasite [1]. Users may have customized that but we cannot account for that here. 1: https://github.com/rbaron/b-parasite/blob/ff113c067778a1d80114cce58965b366f7854c0a/code/nrf-connect/samples/zigbee/Kconfig#L18
|
Yeah b-parasite seems to be the model so strange why someone added plant sensor originally. I've merged this now. |
|
Maybe someone followed some tutorial that changes this and forgot about it? Anyhow, worst case you can add the sensor manually. |
|
Yes, I'd prefer the default rather than everyones custom names but it's hard to know with a lot of submissions if they are truly accurate. |
2 participants
The b-parasite is an open hardware device and the default model is b-parasite [1]. Users may have customized that but we cannot account for that here.