Fix tag available check to refuse prefix matching#82
Merged
Conversation
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched the tag-existence check from
git/refs/tags/{name}(prefix match,returns an array) to
git/ref/tags/{name}(exact match, returns 404 whenabsent). The previous form treated any
200as "tag exists", producing afalse positive whenever a related pre-release tag was already pushed.
For example, with tags
v0.1.0-rc1,v0.1.0-rc2,v0.1.0-rc3present andv0.1.0not:Additional fixes:
${{ github.repository }}moved intoenv:asREPO.${HTTP_STATUS:-000}replaces a|| echo "000"that was bound toawkand never fired on
gh apifailure.