feat: support bitslice for rangebitmap#174
Conversation
src/paimon/common/file_index/rangebitmap/bit_slice_index_bitmap.h
Outdated
Show resolved
Hide resolved
|
/home/runner/work/paimon-cpp/paimon-cpp/src/paimon/common/metrics/histogram_windowing_test.cpp:110: Failure |
It may indeed cause instability. If convenient, you can directly increase the time period, which will make it more stable, or wait for me to make the modifications. |
Thanks for the reply. I can wait for your modification—you're more familiar with the underlying logic. |
There was a problem hiding this comment.
Pull request overview
Adds a Bit-Sliced Index (BSI) bitmap implementation under rangebitmap, enabling EQ/GT/GTE/ISNOTNULL queries with serialization/deserialization support, plus unit tests.
Changes:
- Introduced
BitSliceIndexBitmapwith on-demand slice loading and query operations. - Added unit tests covering functional behavior, random data validation, and edge cases.
- Wired the new implementation and tests into the build via CMake.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/paimon/common/file_index/rangebitmap/bit_slice_index_bitmap.h | Declares the BitSliceIndexBitmap API and Appender serialization interface. |
| src/paimon/common/file_index/rangebitmap/bit_slice_index_bitmap.cpp | Implements serialization format, slice loading, and query evaluation logic. |
| src/paimon/common/file_index/rangebitmap/bit_slice_index_bitmap_test.cpp | Adds UT coverage for equality/range/nullability queries and edge cases. |
| src/paimon/common/file_index/CMakeLists.txt | Adds the new .cpp to the file index library sources. |
| src/paimon/CMakeLists.txt | Registers the new test file in the test build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
src/paimon/common/file_index/rangebitmap/bit_slice_index_bitmap.cpp
Outdated
Show resolved
Hide resolved
src/paimon/common/file_index/rangebitmap/bit_slice_index_bitmap.h
Outdated
Show resolved
Hide resolved
18dbee5 to
5bf5cb3
Compare
|
Nice work! |
Purpose
Linked issue: close #146
Tests
UT tests in
src/paimon/common/file_index/rangebitmap/bit_slice_index_bitmap_test.cpp