-
Notifications
You must be signed in to change notification settings - Fork 266
refactor!: moved ErrInternal to the chain-sdk #2030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6394498
fix: replaced cerrors.Register with cerrors.RegisterWithGRPCCode
vertex451 c997a3c
chore: updated changelog
vertex451 a9bcd5a
Merge branch 'main' of github.com:akash-network/node into artem/fix/5…
vertex451 2d9844e
Merge branch 'main' of github.com:akash-network/node into artem/fix/5…
vertex451 4f5e093
chore: fmt
vertex451 2a00c30
refactor: moved ErrInternal to the chain-sdk
vertex451 577d71e
Merge branch 'main' of github.com:akash-network/node into artem/fix/5…
vertex451 b92d711
refactor: updated pkg.akt.dev/go version
vertex451 9d545aa
chore: increased pkg.akt.dev/go version
vertex451 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package handler_test | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
| "google.golang.org/grpc/codes" | ||
| "google.golang.org/grpc/status" | ||
|
|
||
| "pkg.akt.dev/node/x/provider/handler" | ||
| ) | ||
|
|
||
| func TestErrorGRPCStatusCodes(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| err error | ||
| expectedCode codes.Code | ||
| }{ | ||
| { | ||
| name: "internal_returns_internal", | ||
| err: handler.ErrInternal, | ||
| expectedCode: codes.Internal, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| st, ok := status.FromError(tt.err) | ||
| require.True(t, ok, "error should be convertible to gRPC status") | ||
| require.Equal(t, tt.expectedCode, st.Code(), "gRPC status code mismatch") | ||
| }) | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.