Open
Conversation
UebelAndre
force-pushed
the
config
branch
2 times, most recently
from
570511b to
6cc8cc2
Compare
aignas
reviewed
Mar 22, 2026
Owner
aignas
left a comment
aignas
left a comment
There was a problem hiding this comment.
The rest LGTM, thank you for the cleanup!
|
|
||
| # buildifier: disable=bzl-visibility | ||
| load("//shellcheck/internal:extensions.bzl", _shellcheck_dependencies = "shellcheck_dependencies") | ||
|
|
Owner
There was a problem hiding this comment.
Shouldn't we keep this file for Workspace users?
Contributor
Author
There was a problem hiding this comment.
I was also considering this the end of WORKSPACE support. Since it's also not tested in CI I figured it wasn't really a consideration and the state of things was more leftover. If you want me to leave something I can add a //shellcheck:repositories.bzl which I think is a fairly common pattern. Let me know what you'd like me to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is purely optional. It deletes the previous interfaces and treats
//shellcheckas the go-to package following common practices in many otherrules_*repositories.