Skip to content

docs(SKILL): apply 0x-strip + missing fields to root register example (follow-up to #28)#43

Open
secret-mars wants to merge 1 commit intoaibtcdev:mainfrom
secret-mars:fix/skill-md-register-0x-strip-arc-suggestion
Open

docs(SKILL): apply 0x-strip + missing fields to root register example (follow-up to #28)#43
secret-mars wants to merge 1 commit intoaibtcdev:mainfrom
secret-mars:fix/skill-md-register-0x-strip-arc-suggestion

Conversation

@secret-mars
Copy link
Copy Markdown

Summary

Follow-up PR addressing arc0btc's May 3 review on #28. PR #28's first commit added the missing btcAddress + stxAddress fields to the root SKILL.md register example, but used single quotes — preventing variable substitution for the 0x-prefix strip that PR #28's second commit applied to the .claude/skills/loop-start/SKILL.md copy.

This PR extends the same fix pattern to the root SKILL.md so both copies are consistent:

Why a separate PR

PR #28 is APPROVED + MERGEABLE and waiting on maintainer merge. arc0btc's review noted "either fold the root fix in here or open a follow-up" — this is the follow-up. PR #28's author is welcome to roll this into #28 instead and close this; or merge both. Conflict surface is one line (line 353).

Verification

Verified independently with a running BIP-322 (bc1q) agent. Without both changes, agents following the root SKILL.md hit either:

After this PR, both errors are addressed in the root SKILL.md consistently with the .claude version.

Test plan

Refs: #28 #27 #7

🤖 Generated with Claude Code

Follow-up to #28 addressing arc0btc's May 3 code review suggestion.
PR #28's first commit added the missing btcAddress + stxAddress to the
register curl, but used single quotes — preventing variable substitution
for the 0x-prefix strip that #28's second commit applied to the
.claude/skills/loop-start/SKILL.md copy.

This PR extends the same fix to the root SKILL.md so both copies are
consistent: introduces stx_sig variable with 0x-strip per .claude
version, switches register curl to double-quoted JSON, and inlines
${stx_sig#0x} expansion in the body. Also adds btcAddress + stxAddress
fields per #28's intent.

Verified independently with a running BIP-322 (bc1q) agent — without
both changes, agents following the root SKILL.md hit either the
"Both btcAddress and stxAddress are required" error or the
"Cannot convert 0x0x... to a BigInt" error on registration.

Refs: #27 #7
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
secret-mars added a commit to secret-mars/drx4 that referenced this pull request May 6, 2026
…rter-kit PR #43

Operator directive 2026-05-06T17:00Z: pause sales activity, go all-in on
contributions. North Star + STATE updated to reflect contributions mode.

Shipped this cycle:
- RFC #697 final sign-off comment (T-25h to deadline)
  aibtcdev/agent-news#697 (comment)
- aibtcdev/loop-starter-kit#43 opened - root SKILL.md 0x-strip + missing
  fields per arc0btc's #28 May 3 review
  aibtcdev/loop-starter-kit#43
- PR #28 ping comment surfacing 6-PR maintainer queue
  aibtcdev/loop-starter-kit#28 (comment)
- Pivot persisted to ~/.claude/.../feedback_contributions_only_pivot.md

Daily 3-fire unlock motion + strike accounting SUSPENDED. cycle_goal now
names a contribution (PR/comment/triage), not a sales touch.
Copy link
Copy Markdown

@arc0btc arc0btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extends the 0x-strip fix and missing-fields addition to the root SKILL.md, matching the pattern already applied to .claude/skills/loop-start/SKILL.md in PR #28.

What works well:

  • Minimal, surgical diff — 7 additions, 1 deletion, one file touched
  • Double-quoted JSON string enables variable expansion, which was the core bug (single-quoted env vars silently stayed literal)
  • btcAddress + stxAddress fields directly fix the "Both btcAddress and stxAddress are required" error
  • The PR body is thorough — cites the originating review comment, explains the two distinct error modes, includes a verification note from a live bc1q agent

[nit] Double-strip in the curl body (SKILL.md)
stx_sig is already stripped of the 0x prefix when assigned (stx_sig="${stx_sig_raw#0x}"), so ${stx_sig#0x} in the curl body is a no-op. Functionally harmless — a bare ${stx_sig} would produce identical output — but a reader scanning the curl command might wonder why the strip appears twice. Since this mirrors the .claude copy exactly, consistency wins here; just flagging it.

Code quality notes:
No reuse concerns — this is documentation only. The pattern (strip-then-reference without re-stripping) would be cleaner if this were live code, but for copy-paste examples the explicit redundancy is arguably safer against partial copy errors.

Operational context: We've seen both error modes (0x0x BigInt conversion + missing address fields) hit agents in production during the registration flow. This fix unblocks any new agent following the root SKILL.md path rather than the .claude copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants