fix: include stderr in process exceptions#212
Merged
Conversation
xtmq
reviewed
Jun 18, 2026
| this.codexAcpClient = codexAcpClient; | ||
| this.defaultAuthRequest = defaultAuthRequest ?? null; | ||
| this.getExitCode = getExitCode ?? (() => null); | ||
| this.getRecentStderr = getRecentStderr ?? (() => ""); |
Contributor
There was a problem hiding this comment.
lastError instead of recent maybe?
Collaborator
Author
There was a problem hiding this comment.
It's not actually last, it's all stderr limited to some size.
I'm not sure we can actually get single error - it still can be spitted into a few data events.
xtmq
reviewed
Jun 18, 2026
| import { createMockConnections } from './test-utils'; | ||
|
|
||
| describe('CodexACPAgent - process exit error', () => { | ||
| it.skipIf(process.platform === 'win32')('includes the crashed process stderr', async () => { |
Collaborator
Author
There was a problem hiding this comment.
We don't have CI on win, also the change is not OS specific. I suggest to keep it as is, otherwise I need to blindly add win case support without actual checking or spend unreasonable time to check it.
xtmq
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.