Refonte - Évènements > Factures d'évènement#2211
Open
vgreb wants to merge 1 commit intoafup:masterfrom
Open
Conversation
vgreb
changed the title
vgreb
force-pushed
the
refacto/event-billing
branch
from
5f877fe to
8022fc7
Compare
Collaborator
Author
|
/resolves #2211 |
Mopolo
reviewed
May 7, 2026
Comment on lines
+57
to
+65
| {% if invoice.invoice == 0 %} | ||
| A facturer | ||
| {% elseif invoice.invoice == 1 %} | ||
| Facturée | ||
| {% elseif invoice.invoice == 2 %} | ||
| Reçue | ||
| {% else %} | ||
| -- | ||
| {% endif %} |
Contributor
There was a problem hiding this comment.
Je ne comprends pas ce bloc.
Dans l'entité c'est un bool, dans le repository aussi. Est-ce que c'est la bonne propriété ici ?
Et j'ai vérifié dans la base de prod, il n'y a que 0 et 1 comme valeurs dans la colonne.
Collaborator
Author
There was a problem hiding this comment.
Le template legacy utilise la colonne facturation qui correspond à la propriété invoice du modèle AppBundle\Event\Model\Invoice.
Je n'ai pas vérifié si template était cohérent avec chacune des valeur possibles de propriétés.
Collaborator
Author
There was a problem hiding this comment.
J'ai remplacé par :
{% if invoice.invoice %}
Facturée
{% else %}
À facturer
{% endif %}
vgreb
force-pushed
the
refacto/event-billing
branch
from
8022fc7 to
21c59cd
Compare
Je n'ai pas repris le javascript de changement de date de facturation, celui-ci ne fonctionne pas depuis plusieurs années
vgreb
force-pushed
the
refacto/event-billing
branch
from
21c59cd to
92eeb01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
La MR intègre la refonte de la liste des facture d'évènements ainsi que les actions associées (téléchargement devis/facture, envoi d'une facture, suppression, etc)
Je n'ai pas repris le javascript de changement de date de facturation, celui-ci ne fonctionne pas depuis plusieurs années