fix(session): move cookie name to root level cookieName config#9
Closed
philippe-desplats wants to merge 2 commits intoadonisjs:mainfrom
Closed
fix(session): move cookie name to root level cookieName config#9philippe-desplats wants to merge 2 commits intoadonisjs:mainfrom
philippe-desplats wants to merge 2 commits intoadonisjs:mainfrom
Conversation
Member
|
Looks good. Can you please remove the |
ca88adb to
e8c08f6
Compare
Author
|
Done! I removed |
Member
|
Fixed in one of the other commits! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
• Corrects the session documentation to reflect the actual API:
cookieNameis a root-level config option, notcookie.name• Updates the default config example to show
cookieName: 'adonis-session'instead of nestedcookie.name• Documents
cookieNameas a proper config option in the reference section• Removes the incorrect
cookie.nameoption from the Cookie configuration sectionChanges
cookieNameto root level in the default config examplenameproperty from the nestedcookieobjectcookieNameto the configuration options documentationcookie.nameoption documentationcookieoption description (removed mention of "cookie name")