Skip to content

fix(session): move cookie name to root level cookieName config#9

Closed
philippe-desplats wants to merge 2 commits intoadonisjs:mainfrom
philippe-desplats:fix/session-cookie-name-config
Closed

fix(session): move cookie name to root level cookieName config#9
philippe-desplats wants to merge 2 commits intoadonisjs:mainfrom
philippe-desplats:fix/session-cookie-name-config

Conversation

@philippe-desplats
Copy link
Copy Markdown

Summary

• Corrects the session documentation to reflect the actual API: cookieName is a root-level config option, not cookie.name
• Updates the default config example to show cookieName: 'adonis-session' instead of nested cookie.name
• Documents cookieName as a proper config option in the reference section
• Removes the incorrect cookie.name option from the Cookie configuration section

Changes

  • content/guides/basics/session.md:
    • Moved cookieName to root level in the default config example
    • Removed name property from the nested cookie object
    • Added cookieName to the configuration options documentation
    • Removed incorrect cookie.name option documentation
    • Updated the cookie option description (removed mention of "cookie name")

@thetutlage
Copy link
Copy Markdown
Member

Looks good. Can you please remove the package-lock.json file from changes, as that is not relevant to this change

@philippe-desplats philippe-desplats force-pushed the fix/session-cookie-name-config branch from ca88adb to e8c08f6 Compare March 9, 2026 16:36
@philippe-desplats
Copy link
Copy Markdown
Author

Done! I removed package-lock.json and .env.example from the changes. The PR now only contains the session.md fix.

@thetutlage
Copy link
Copy Markdown
Member

Fixed in one of the other commits!

@thetutlage thetutlage closed this Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants