Skip to content

fix: add onAction type to RAC TagGroup#9222

Merged
devongovett merged 9 commits intoadobe:mainfrom
onx2:main
Mar 17, 2026
Merged

fix: add onAction type to RAC TagGroup#9222
devongovett merged 9 commits intoadobe:mainfrom
onx2:main

Conversation

@onx2
Copy link
Copy Markdown
Contributor

@onx2 onx2 commented Nov 21, 2025

Closes #9205

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

onAction works for React Aria Component's TagGroup and is a valid group-level prop.

🧢 Your Project:

Weights & Biases component library (currently private)

Copy link
Copy Markdown
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spent a little time on this today, will have some things to resolve, noted as a code comment

@github-actions github-actions Bot added the RAC label Mar 17, 2026
Copy link
Copy Markdown
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against ListBox, they behave the same, so this is approved

@devongovett devongovett added this pull request to the merge queue Mar 17, 2026
Merged via the queue into adobe:main with commit f8bb8ae Mar 17, 2026
28 checks passed
@yihuiliao yihuiliao added the no testing Does not require manual testing during testing session label Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no testing Does not require manual testing during testing session RAC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TagGroup onAction

4 participants