Skip to content

chore: generalise reading values from meta tags - #10433

Merged
LFDanLu merged 1 commit into
mainfrom
pull-out-getMetaValue-improvement
Aug 13, 2026
Merged

chore: generalise reading values from meta tags#10433
LFDanLu merged 1 commit into
mainfrom
pull-out-getMetaValue-improvement

Conversation

@snowystinger

Copy link
Copy Markdown
Member

Closes

Pulled out of #10102 with tests to show what it's doing and to make the original PR smaller and easier to review

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot

rspbot commented Aug 7, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Aug 7, 2026

Copy link
Copy Markdown

Agent Skills Changes

Modified (2)
Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/7bc33c630359f05c3ed7e80bf6e97dbb5766eef4/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/7bc33c630359f05c3ed7e80bf6e97dbb5766eef4/

@devongovett

Copy link
Copy Markdown
Member

Are we going to use this for something else?

@nwidynski

nwidynski commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@devongovett Do you mean apart from #10102? That PR generalized it to be re-used for the interactive-widget meta value.

@snowystinger snowystinger added the no testing Does not require manual testing during testing session label Aug 10, 2026
@LFDanLu
LFDanLu added this pull request to the merge queue Aug 13, 2026
Merged via the queue into main with commit 3543f21 Aug 13, 2026
31 checks passed
@LFDanLu
LFDanLu deleted the pull-out-getMetaValue-improvement branch August 13, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no testing Does not require manual testing during testing session ready for review small review Easy to review PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants