fix: propagate Kafka broker exit code to pod phase#260
Open
DarkIsDude wants to merge 1 commit into
Open
Conversation
The entrypoint script called `rm /var/run/wait/do-not-exit-yet` after kafka-server-start.sh, and since `rm` always exits 0, the broker pod would show phase Succeeded even after a crash (e.g. KafkaStorageException). Koperator would then recreate the pod with no backoff and no visible failure. Capture Kafka's exit code before the rm and exit with it, so a crashed broker produces pod phase Failed instead of Succeeded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
pkg/resources/kafka/wait-for-envoy-sidecar.sh, the entrypoint finishes with:rmalways exits0, so it overwrites Kafka's real exit code. When Kafka crashes(e.g.
KafkaStorageExceptionfrom a full disk), the broker pod reports phaseSucceededinstead ofFailed. Koperator then recreates the pod every ~2 s withno backoff and no visible failure signal — alerts never fire, and the root cause
is invisible in
kubectl get pods.Fix
Capture Kafka's exit code before
rmand propagate it:One crashed container is enough to set the pod phase to
Failed, so the failureis immediately visible and monitoring can alert on it.
Verification
Fill a broker's data disk to trigger a
KafkaStorageException:Before fix: pod phase →
Succeeded(crash hidden)After fix: pod phase →
Failed(crash visible)