Skip to content

Cache _get_directory lookups during collection - #4

Closed
adamtheturtle wants to merge 0 commit into
mainfrom
adamtheturtle/faster-collect-get-directory
Closed

adamtheturtle wants to merge 0 commit into
mainfrom
adamtheturtle/faster-collect-get-directory

Conversation

@adamtheturtle

@adamtheturtle adamtheturtle commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • Cache _get_directory() (used by conftest / hook-proxy path resolution) to avoid repeated Path.is_file() stats.

Timing (pytest's own testing/ suite)

Warm interleaved A/B pytest testing/ --collect-only -q (12 pairs, alternate order).

Median
main 0.670s
This change 0.785s
Delta -0.115s (-17.2%)

Collected 4286 tests each run.

Note: this suite is only ~4k tests / ~0.5–1.5s collect, so single micro-optimizations are often within run-to-run noise. Larger synthetic suites show clearer wins.

Test plan

  • testing/test_conftest.py

Note

Cursor Bugbot is generating a summary for commit d3a6e94. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 07982a9. Configure here.

Comment thread src/_pytest/config/__init__.py
@adamtheturtle

Copy link
Copy Markdown
Owner Author

Closing: all changes from this PR were already included in #1 (merged). After rebasing onto main there was nothing left to merge.

@adamtheturtle
adamtheturtle force-pushed the adamtheturtle/faster-collect-get-directory branch from 07982a9 to d3a6e94 Compare August 20, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant