Skip to content

espressif_bindings/Camera.c: fix type of framebuffer_count#10772

Merged
tannewt merged 3 commits intoadafruit:10.0.xfrom
dhalbert:10.0.x-fix-espcamera-reconfigure
Jan 5, 2026
Merged

espressif_bindings/Camera.c: fix type of framebuffer_count#10772
tannewt merged 3 commits intoadafruit:10.0.xfrom
dhalbert:10.0.x-fix-espcamera-reconfigure

Conversation

@dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Jan 5, 2026

framebuffer_count was mistakenly declared as a bool instead of an mp_int_t, causing it to be restricted to being only 0 or 1.

@smolbun could you test this after the builds are finished? Thanks.

@dhalbert dhalbert requested a review from tannewt January 5, 2026 03:27
@dhalbert
Copy link
Collaborator Author

dhalbert commented Jan 5, 2026

@smolbun reports this fixes the issue: #10770 (comment).

I cherry-picked fixes from #10706 to get the macos builds working again.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit dae495f into adafruit:10.0.x Jan 5, 2026
629 checks passed
@dhalbert dhalbert deleted the 10.0.x-fix-espcamera-reconfigure branch January 6, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants