fix(GH-2284): Put docker:dind in proper cgroup parent#4480
Open
marverix wants to merge 1 commit intoactions:masterfrom
Open
fix(GH-2284): Put docker:dind in proper cgroup parent#4480marverix wants to merge 1 commit intoactions:masterfrom
marverix wants to merge 1 commit intoactions:masterfrom
Conversation
marverix
requested review from
a team,
Steve-Glass,
mumoshu,
nikola-jokic,
rentziass and
toast-gear
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to address GH-2284 by configuring the Docker-in-Docker (docker:dind) daemon to place nested Docker containers under the runner Pod’s cgroup via dockerd --cgroup-parent, improving cgroupv2 resource accounting/limits behavior.
Changes:
- Add a
--cgroup-parent=...flag to the dinddockerdargs. - Inject the Pod UID into the dind container via the Downward API (
metadata.uid) for use in the cgroup parent path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+118
to
+125
| - --cgroup-parent=/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod${POD_UID//-/_}.slice | ||
| env: | ||
| - name: DOCKER_GROUP_GID | ||
| value: "123" | ||
| - name: POD_UID | ||
| valueFrom: | ||
| fieldRef: | ||
| fieldPath: metadata.uid |
| - dockerd | ||
| - --host=unix:///var/run/docker.sock | ||
| - --group=$(DOCKER_GROUP_GID) | ||
| - --cgroup-parent=/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod${POD_UID//-/_}.slice |
| - dockerd | ||
| - --host=unix:///var/run/docker.sock | ||
| - --group=$(DOCKER_GROUP_GID) | ||
| - --cgroup-parent=/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod${POD_UID//-/_}.slice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR is fix for ticket openeded since 2023: #2284 .
The idea is to use dockerd cgroup-parent flag to put dind containers in proper control groups.