Repository navigation
refactor: standardize complete performance reports - #277
Merged
Merged
Conversation
- Use shared rendering and configured publication for complete-run reports. - Preserve dimension plots, historical report bytes, and immutable evidence. - Align report guidance with retained provenance and make the Cargo shell fixture use LF on Windows. Refs #276
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
==========================================
- Coverage 98.12% 98.11% -0.02%
==========================================
Files 14 14
Lines 7112 7112
==========================================
- Hits 6979 6978 -1
- Misses 133 134 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete performance runs now use the shared research-repo-tools renderer for scratch and published reports. Configuration in
tooling/performance-report.tomlselects the title anddocs/performance.mddestination, replacing the local full-report renderer and duplicate publication assembly.This uses the published research-repo-tools 0.1.8 APIs. It prepares for #276; v0.1.9 adoption and the remaining shared capabilities stay open there.
Validation:
just check python-cipassed on macOS, including all 371 Python tests, type checking, lint/config checks, documentation checks, and spelling. An isolated check of the generated Cargo fixture reproduced a shell syntax failure with Windows-style CRLF output and succeeded with the repaired LF output. This is a macOS model; native Linux and Windows results remain pending on this PR.Refs #276
Summary by CodeRabbit
Documentation
Bug Fixes