Skip to content

[Cleanup] Remove C3 and D3 library#10328

Merged
driusan merged 1 commit intoaces:mainfrom
driusan:RemoveC3D3
Apr 20, 2026
Merged

[Cleanup] Remove C3 and D3 library#10328
driusan merged 1 commit intoaces:mainfrom
driusan:RemoveC3D3

Conversation

@driusan
Copy link
Copy Markdown
Collaborator

@driusan driusan commented Feb 5, 2026

These libraries do not appear to be used anywhere but are in htdocs, unmanaged by npm.

At one point they were used for visualizations, but they are no longer used on the dashboard widgets and I could not find any references to them. "c3" and "d3" are common in hex strings, so it's possible I missed one, but as far as I can tell these are no longer necessary.

@driusan driusan added Category: Cleanup PR or issue introducing/requiring at least one clean-up operation Language: Javascript PR or issue that update Javascript code labels Feb 5, 2026
@CamilleBeau CamilleBeau self-assigned this Feb 16, 2026
Copy link
Copy Markdown
Collaborator

@CamilleBeau CamilleBeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing c3 still used in places like the imaging browser, statistics, dqt

e.g.

import '../../../node_modules/c3/c3.css';

@CamilleBeau CamilleBeau assigned driusan and unassigned CamilleBeau Mar 2, 2026
These libraries do not appear to be used anywhere but are in htdocs, unmanaged by npm.

At one point they were used for visualizations, but they are no longer used on the dashboard
widgets and I could not find any references to them. "c3" and "d3" are common in hex strings,
so it's possible I missed one, but as far as I can tell these are no longer necessary.
@driusan
Copy link
Copy Markdown
Collaborator Author

driusan commented Mar 11, 2026

@CamilleBeau That is being imported from node_modules (ie. using the version of C3 managed by npm.)

This is only deleting the copy in htdocs.

@CamilleBeau CamilleBeau added the Passed manual tests PR has been successfully tested by at least one peer label Apr 20, 2026
@driusan driusan merged commit 93e8e03 into aces:main Apr 20, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category: Cleanup PR or issue introducing/requiring at least one clean-up operation Language: Javascript PR or issue that update Javascript code Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants