Fix incorrect license detection in dragon4.c#4654
Open
Kaushik-Kumar-CEG wants to merge 2 commits intoaboutcode-org:developfrom
Open
Fix incorrect license detection in dragon4.c#4654Kaushik-Kumar-CEG wants to merge 2 commits intoaboutcode-org:developfrom
Kaushik-Kumar-CEG wants to merge 2 commits intoaboutcode-org:developfrom
Conversation
4b4cfb7 to
c0a80f5
Compare
9180bfd to
55ff6f1
Compare
Author
|
@pombredanne @AyanSinhaMahapatra This PR resolves the false positive All checks have passed Ready for your review! |
Member
|
Thanks! This is overall looking good. Can you add two detection tests (one for the false positive and one for the clue?) |
- Change 'license-intro_8.RULE' to a license clue to prevent false positives. - Add 'false-positive_dragon4.RULE' to ignore specific text in NumPy. Fixes aboutcode-org#4584 Signed-off-by: Kaushik <kaushikrjpm10@gmail.com>
Signed-off-by: Kaushik <kaushikrjpm10@gmail.com>
55ff6f1 to
1403d87
Compare
Author
I have added two necessary detection tests :
I have attached the results for both these tests as images (terminal outputs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #4584
Description
This PR fixes an incorrect license detection in NumPy's
dragon4.c, where the text "As a special exception" was incorrectly triggering ageneric-exceptionmatch.Changes:
license-intro_8.RULE: Downgraded this rule fromis_license_introtois_license_clue. This ensures the phrase contributes to evidence but does not trigger a false positive when found alone.false-positive_dragon4.RULE: Added a specific false positive rule to ignore the misleading text ("As a special exception the smallest normal value") found indragon4.c.Verification:
generic-exceptionwas originally detected.license-intro_8.RULEcorrectly behaves as a clue (no detection) when isolated.Tasks