Skip to content

Replace bitmap-backed Visual Studio icons with ImageMonikers#1921

Merged
RobertvanderHulst merged 4 commits intomainfrom
copilot/replace-bitmap-images-with-imagemonikers
May 7, 2026
Merged

Replace bitmap-backed Visual Studio icons with ImageMonikers#1921
RobertvanderHulst merged 4 commits intomainfrom
copilot/replace-bitmap-images-with-imagemonikers

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 7, 2026

Summary

  • replace the remaining bitmap-backed command icons in src/VisualStudio/ProjectPackage/Menus.vsct with image catalog monikers
  • switch the VS 2022 X# project node, X# file node mappings, and shared reference container node to moniker-based hierarchy icons
  • stop relying on the custom X# bitmap strip for these DEV17 command and hierarchy icon paths

Validation

  • git --no-pager diff --check
  • XML parse of /home/runner/work/XSharpPublic/XSharpPublic/src/VisualStudio/ProjectPackage/Menus.vsct
  • dotnet build src/VSIntegration2022.sln -c Debug -v minimal (fails in this Linux sandbox because the repo's VS integration projects require Visual Studio/VSSDK targets, XSharp build props, and .NET Framework targeting packs)

Copilot AI and others added 4 commits May 7, 2026 11:18
Agent-Logs-Url: https://github.com/X-Sharp/XSharpPublic/sessions/b75c3f68-25d5-43cb-8b05-eda0b09e0246

Co-authored-by: RobertvanderHulst <14240939+RobertvanderHulst@users.noreply.github.com>
Agent-Logs-Url: https://github.com/X-Sharp/XSharpPublic/sessions/b75c3f68-25d5-43cb-8b05-eda0b09e0246

Co-authored-by: RobertvanderHulst <14240939+RobertvanderHulst@users.noreply.github.com>
Agent-Logs-Url: https://github.com/X-Sharp/XSharpPublic/sessions/b75c3f68-25d5-43cb-8b05-eda0b09e0246

Co-authored-by: RobertvanderHulst <14240939+RobertvanderHulst@users.noreply.github.com>
Agent-Logs-Url: https://github.com/X-Sharp/XSharpPublic/sessions/b75c3f68-25d5-43cb-8b05-eda0b09e0246

Co-authored-by: RobertvanderHulst <14240939+RobertvanderHulst@users.noreply.github.com>
Copilot AI requested a review from RobertvanderHulst May 7, 2026 11:23
@RobertvanderHulst RobertvanderHulst marked this pull request as ready for review May 7, 2026 11:58
Copilot AI review requested due to automatic review settings May 7, 2026 11:58
@RobertvanderHulst RobertvanderHulst merged commit 01fa22c into main May 7, 2026
4 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request modernizes the Visual Studio integration icons by moving remaining command and hierarchy visuals away from a custom bitmap strip and onto Visual Studio’s Image Catalog monikers (especially for VS 2022 / DEV17). This reduces reliance on bitmap-backed resources and aligns the extension UI with standard VS icon theming.

Changes:

  • Updated Menus.vsct commands to use ImageCatalogGuid moniker icons (and removed the custom bitmap strip registration).
  • Switched VS 2022 (DEV17) hierarchy icons for the X# project node and reference container to moniker-based icons.
  • Consolidated X# file-extension-to-moniker mappings for better maintainability.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/VisualStudio/ProjectPackage/Nodes/XSharpProjectNode.cs Uses icon monikers for the project node under DEV17 and gates bitmap image list loading/usage to non-DEV17.
src/VisualStudio/ProjectPackage/Nodes/XSharpFileNode.cs Refactors and expands extension→moniker mappings; simplifies DEV17 moniker support logic.
src/VisualStudio/ProjectPackage/Menus.vsct Replaces bitmap-backed command icons with Image Catalog monikers and removes the bitmap strip symbol/registration.
src/VisualStudio/ProjectBase/ReferenceContainerNode.cs Enables moniker icons for the reference container under DEV17 and avoids bitmap-handle lookup in that configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RobertvanderHulst RobertvanderHulst deleted the copilot/replace-bitmap-images-with-imagemonikers branch May 7, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants