Skip to content

KSES: Allow autofocus attribute only on the dialog element. #12682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afercia wants to merge 1 commit into
base: trunk
Choose a base branch
from
+16 −3
Open

KSES: Allow autofocus attribute only on the dialog element. #12682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/wp-includes/kses.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,10 @@
'popover' => true,
),
'dialog' => array(
'closedby' => true,
'open' => true,
'popover' => true,
'closedby' => true,
'open' => true,
'popover' => true,
'autofocus' => true,
),
'dl' => array(),
'dt' => array(),
Expand Down
12 changes: 12 additions & 0 deletions tests/phpunit/tests/kses.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2183,6 +2183,18 @@ public function test_wp_kses_main_tag_standard_attributes() {
$this->assertEqualHTML( $html, wp_kses_post( $html ) );
}

/**
* Tests that the autofocus attribute is allowed on dialog elements and removed from other focusable elements.
*
* @ticket 65491
*/
public function test_wp_kses_dialog_autofocus_attribute() {
$html = '<dialog open autofocus>Content</dialog><button type="button" autofocus>Button</button><textarea autofocus>Some content</textarea><div tabindex="0" autofocus>Some content</div>';
$expected = '<dialog open autofocus>Content</dialog><button type="button">Button</button><textarea>Some content</textarea><div tabindex="0">Some content</div>';

$this->assertEqualHTML( $expected, wp_kses_post( $html ) );
}

/**
* Test that Invoker Commands API attributes are preserved on buttons in post content.
*
Expand Down
Loading