REST API: Normalize non-integer attachment filesize metadata#12611

Closed

apermo wants to merge 28 commits into

WordPress:trunkfrom

apermo:trac-65670-attachment-filesize-typeerror

Commits on Jul 20, 2026

fix(rest): cast string filesize meta to int

apermo
and
claude
committed
docs(rest): trim filesize guard comment per review

apermo
and
claude
committed

Commits on Jul 21, 2026

Eliminate legacy args for create_object() and add assertions to fix PHPStan issues in tests
westonruter
committed
fix(rest): require positive integer filesize meta

apermo
and
claude
committed
fix(rest): guard ctype_digit against non-string meta

apermo
and
claude
committed
Remove change to unrelated test
westonruter
committed
Add typing to data provider
westonruter
committed
Remove extra line break
westonruter
committed
Ensure wp_filesize() never returns a negative number
westonruter
committed
Reformat multi-line conditional
westonruter
committed
Merge branch 'trunk' into trac-65670-attachment-filesize-typeerror
westonruter
committed
Make it clear a non-negative-int is required for the short-circuit to work
westonruter
committed
Only cast numeric values to integer; treat others as zero
westonruter
committed
Add tests
westonruter
committed
Improve formatting of arrow functions

westonruter
and
Copilot
authored
Update filesize key in metadata alone

westonruter
and
Copilot
committed
Use attachment's resolved path

westonruter
and
Copilot
committed
Relax attachment metadata filesize to include numeric values
westonruter
committed
Improve wording of since tag
westonruter
committed
Improve name of test method
westonruter
committed
Indicate that filesize may be null in REST API response
westonruter
committed
Improve data provider name
westonruter
committed
Add tests for numeric-string as wp_filesize and pre_wp_filesize filtered value
westonruter
committed
Clarify numeric value vs numeric string
westonruter
committed
Improve wording of wp_filesize() docblocks

westonruter
and
claude
committed
Add negative value test for pre_wp_filesize
westonruter
committed
Add data provider for negative pre_wp_filesize filter values

westonruter
and
claude
committed
Improve param name

westonruter
and
Copilot
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

REST API: Normalize non-integer attachment filesize metadata#12611

REST API: Normalize non-integer attachment filesize metadata#12611
apermo wants to merge 28 commits into
WordPress:trunkfrom
apermo:trac-65670-attachment-filesize-typeerror

Commits on Jul 20, 2026

fix(rest): cast string filesize meta to int

docs(rest): trim filesize guard comment per review

Commits on Jul 21, 2026

Eliminate legacy args for create_object() and add assertions to fix PHPStan issues in tests

fix(rest): require positive integer filesize meta

fix(rest): guard ctype_digit against non-string meta

Remove change to unrelated test

Add typing to data provider

Remove extra line break

Ensure wp_filesize() never returns a negative number

Reformat multi-line conditional

Merge branch 'trunk' into trac-65670-attachment-filesize-typeerror

Make it clear a non-negative-int is required for the short-circuit to work

Only cast numeric values to integer; treat others as zero

Add tests

Improve formatting of arrow functions

Update filesize key in metadata alone

Use attachment's resolved path

Relax attachment metadata filesize to include numeric values

Improve wording of since tag

Improve name of test method

Indicate that filesize may be null in REST API response

Improve data provider name

Add tests for numeric-string as wp_filesize and pre_wp_filesize filtered value

Clarify numeric value vs numeric string

Improve wording of wp_filesize() docblocks

Add negative value test for pre_wp_filesize

Add data provider for negative pre_wp_filesize filter values

Improve param name