-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Build: Restore block parser in Core. #10761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Trac ticket: Core-64521 The work in WordPress#10638 [[61438]](https://core.trac.wordpress.org/changeset/61438) for Core-64393 removed the block parser classes from Core, which caused numerous scripts to fail because they were missing. Conditional checks were added in WordPress#10718 [[61492]](https://core.trac.wordpress.org/changeset/61492) which left WordPress in an inoperable state. This patch restores the block parser in Core, in preparation for work to remove it from Gutenberg (in a separate patch f. Ironically, the files were removed because the new build was copying them over from Gutenberg and the intent was to avoid having two sources of truth, but this was previously the existing mechanism, so having done nothing to the parser files would have left the status quo. This patch removes the problems originally created by removing the files. They will not be copied from Gutenberg any more and the only source of truth will be Core. Until removed from Gutenberg, because of the build changes, any changes made on the Gutenberg side will be lost unless manually copied over. Developed in: WordPress#10761 Discussed in: https://core.trac.wordpress.org/ticket/64521 Follow-up to [61438], [61492]. Props dmsnell, mcsf, mukesh27, youknowriad. Co-authored-by: Miguel Fonseca <mcsf@git.wordpress.org> Co-authored-by: Mukesh Panchal <mukesh27@git.wordpress.org> Co-authored-by: Riad Benguella <youknowriad@git.wordpress.org> Github-PR: 10761 Github-PR-URL: WordPress#10761 Trac-Ticket: 64521 Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64521 Branch-Name: build/restore-block-parser
a6f1e7d to
bcb21f0
Compare
Trac ticket: Core-64521 The work in WordPress#10638 [[61438]](https://core.trac.wordpress.org/changeset/61438) for Core-64393 removed the block parser classes from Core, which caused numerous scripts to fail because they were missing. Conditional checks were added in WordPress#10718 [[61492]](https://core.trac.wordpress.org/changeset/61492) which left WordPress in an inoperable state. This patch restores the block parser in Core, in preparation for work to remove it from Gutenberg (in a separate patch f. Ironically, the files were removed because the new build was copying them over from Gutenberg and the intent was to avoid having two sources of truth, but this was previously the existing mechanism, so having done nothing to the parser files would have left the status quo. This patch removes the problems originally created by removing the files. They will not be copied from Gutenberg any more and the only source of truth will be Core. Until removed from Gutenberg, because of the build changes, any changes made on the Gutenberg side will be lost unless manually copied over. Developed in: WordPress#10761 Discussed in: https://core.trac.wordpress.org/ticket/64521 Follow-up to [61438], [61492]. Props dmsnell, mcsf, mukesh27, youknowriad. Co-authored-by: Miguel Fonseca <mcsf@git.wordpress.org> Co-authored-by: Mukesh Panchal <mukesh27@git.wordpress.org> Co-authored-by: Riad Benguella <youknowriad@git.wordpress.org> Github-PR: 10761 Github-PR-URL: WordPress#10761 Trac-Ticket: 64521 Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64521 Branch-Name: build/restore-block-parser
bcb21f0 to
9364afc
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
9364afc to
191d64a
Compare
Trac ticket: Core-64521 The work in WordPress#10638 [[61438]](https://core.trac.wordpress.org/changeset/61438) for Core-64393 removed the block parser classes from Core, which caused numerous scripts to fail because they were missing. Conditional checks were added in WordPress#10718 [[61492]](https://core.trac.wordpress.org/changeset/61492) which left WordPress in an inoperable state. This patch restores the block parser in Core, in preparation for work to remove it from Gutenberg (in a separate patch). Ironically, the files were removed because the new build was copying them over from Gutenberg and the intent was to avoid having two sources of truth, but this was previously the existing mechanism, so having done nothing to the parser files would have left the status quo. This patch removes the problems originally created by removing the files. They will not be copied from Gutenberg any more and the only source of truth will be Core. Until removed from Gutenberg, because of the build changes, any changes made on the Gutenberg side will be lost unless manually copied over. Developed in: WordPress#10761 Discussed in: https://core.trac.wordpress.org/ticket/64521 Follow-up to [61438], [61492]. Props dmsnell, mcsf, mukesh27, youknowriad. Co-authored-by: Miguel Fonseca <mcsf@git.wordpress.org> Co-authored-by: Mukesh Panchal <mukesh27@git.wordpress.org> Co-authored-by: Riad Benguella <youknowriad@git.wordpress.org> Github-PR: 10761 Github-PR-URL: WordPress#10761 Trac-Ticket: 64521 Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64521 Branch-Name: build/restore-block-parser
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
This looks good to me :) |
Trac ticket: Core-64521 The work in WordPress#10638 [[61438]](https://core.trac.wordpress.org/changeset/61438) for Core-64393 removed the block parser classes from Core, which caused numerous scripts to fail because they were missing. Conditional checks were added in WordPress#10718 [[61492]](https://core.trac.wordpress.org/changeset/61492) which left WordPress in an inoperable state. This patch restores the block parser in Core, in preparation for work to remove it from Gutenberg (in a separate patch). Ironically, the files were removed because the new build was copying them over from Gutenberg and the intent was to avoid having two sources of truth, but this was previously the existing mechanism, so having done nothing to the parser files would have left the status quo. This patch removes the problems originally created by removing the files. They will not be copied from Gutenberg any more and the only source of truth will be Core. Until removed from Gutenberg, because of the build changes, any changes made on the Gutenberg side will be lost unless manually copied over. Developed in: WordPress#10761 Discussed in: https://core.trac.wordpress.org/ticket/64521 Follow-up to [61438], [61492]. Props dmsnell, mcsf, mukesh27, youknowriad. Co-authored-by: Miguel Fonseca <mcsf@git.wordpress.org> Co-authored-by: Mukesh Panchal <mukesh27@git.wordpress.org> Co-authored-by: Riad Benguella <youknowriad@git.wordpress.org> Github-PR: 10761 Github-PR-URL: WordPress#10761 Trac-Ticket: 64521 Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64521 Branch-Name: build/restore-block-parser
191d64a to
0d34362
Compare
The work in [61438] for Core-64393 removed the block parser classes from Core, which caused numerous scripts to fail because they were missing. Conditional checks were added in [61492] which left WordPress in an inoperable state. This patch restores the block parser in Core, in preparation for work to remove it from Gutenberg (in a separate patch). Ironically, the files were removed because the new build was copying them over from Gutenberg and the intent was to avoid having two sources of truth, but this was previously the existing mechanism, so having done nothing to the parser files would have left the status quo. This patch removes the problems originally created by removing the files. They will not be copied from Gutenberg any more and the only source of truth will be Core. Until removed from Gutenberg, because of the build changes, any changes made on the Gutenberg side will be lost unless manually copied over. Developed in: #10761 Discussed in: https://core.trac.wordpress.org/ticket/64521 Follow-up to [61438], [61492]. Props dmsnell, mcsf, mukesh27, youknowriad. Fixes #64521. git-svn-id: https://develop.svn.wordpress.org/trunk@61504 602fd350-edb4-49c9-b593-d223f7449a82
The work in [61438] for Core-64393 removed the block parser classes from Core, which caused numerous scripts to fail because they were missing. Conditional checks were added in [61492] which left WordPress in an inoperable state. This patch restores the block parser in Core, in preparation for work to remove it from Gutenberg (in a separate patch). Ironically, the files were removed because the new build was copying them over from Gutenberg and the intent was to avoid having two sources of truth, but this was previously the existing mechanism, so having done nothing to the parser files would have left the status quo. This patch removes the problems originally created by removing the files. They will not be copied from Gutenberg any more and the only source of truth will be Core. Until removed from Gutenberg, because of the build changes, any changes made on the Gutenberg side will be lost unless manually copied over. Developed in: WordPress/wordpress-develop#10761 Discussed in: https://core.trac.wordpress.org/ticket/64521 Follow-up to [61438], [61492]. Props dmsnell, mcsf, mukesh27, youknowriad. Fixes #64521. Built from https://develop.svn.wordpress.org/trunk@61504 git-svn-id: http://core.svn.wordpress.org/trunk@60815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The work in [61438] for Core-64393 removed the block parser classes from Core, which caused numerous scripts to fail because they were missing. Conditional checks were added in [61492] which left WordPress in an inoperable state. This patch restores the block parser in Core, in preparation for work to remove it from Gutenberg (in a separate patch). Ironically, the files were removed because the new build was copying them over from Gutenberg and the intent was to avoid having two sources of truth, but this was previously the existing mechanism, so having done nothing to the parser files would have left the status quo. This patch removes the problems originally created by removing the files. They will not be copied from Gutenberg any more and the only source of truth will be Core. Until removed from Gutenberg, because of the build changes, any changes made on the Gutenberg side will be lost unless manually copied over. Developed in: WordPress#10761 Discussed in: https://core.trac.wordpress.org/ticket/64521 Follow-up to [61438], [61492]. Props dmsnell, mcsf, mukesh27, youknowriad. Fixes #64521. git-svn-id: https://develop.svn.wordpress.org/trunk@61504 602fd350-edb4-49c9-b593-d223f7449a82
Quick summary
Summary
Trac ticket: Core-64521
See also: Core-64393
The work in #10638 [61438] for Core-64393 removed the block parser classes from Core, which caused numerous scripts to fail because they were missing. Conditional checks were added in #10718 [61492] which left WordPress in an inoperable state.
This patch restores the block parser in Core, in preparation for work to remove it from Gutenberg (in a separate patch).
Ironically, the files were removed because the new build was copying them over from Gutenberg and the intent was to avoid having two sources of truth, but this was previously the existing mechanism, so having done nothing to the parser files would have left the status quo. This patch removes the problems originally created by removing the files. They will not be copied from Gutenberg any more and the only source of truth will be Core.
Until removed from Gutenberg, because of the build changes, any changes made on the Gutenberg side will be lost unless manually copied over.
Developed in: #10761
Discussed in: https://core.trac.wordpress.org/ticket/64521
Follow-up to [61438], [61492].
Props dmsnell, mcsf, mukesh27, youknowriad.