Open
Conversation
44e51d0 to
2d4457b
Compare
Signed-off-by: ddeviatilov <9.tilov@gmail.com>
msfjarvis
requested changes
Sep 19, 2025
| this.owner = owner; | ||
| } | ||
|
|
||
| private void startForeground() { |
Member
There was a problem hiding this comment.
This can't exist in the library because it's meant to be reusable for other apps that aren't the official WireGuard app. We'll have to either expose a separate API to let integrators provide their own notification or just move this fully to the ui module.
Author
There was a problem hiding this comment.
I agree it's not the best solution but now it's quite tricky to run this VPN service on a new devices without foreground service support because Android system becomes more and more strict and can kill Vpn service.
You can read about it here.
Do we have a plan/workaround how to promote service to foreground?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.