[GStreamer] change network state to idle when delaying the load #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes applications create a <video> tag with 'preload="none"' and then remove the element from the DOM without ever starting playback. This results in the video element being leaked, because HTMLMediaElement::virtualHasPendingActivity() retains the element while its network state is still "Loading".
eocanha
added
the
upstream
eocanha
added a commit
to eocanha/WebKit
that referenced
this pull request
Jan 14, 2026
https://bugs.webkit.org/show_bug.cgi?id=305473 Reviewed by NOBODY (OOPS!). Sometimes applications create a <video> tag with 'preload="none"' and then remove the element from the DOM without ever starting playback. This results in the video element being leaked, because HTMLMediaElement::virtualHasPendingActivity() retains the element while its network state is still "Loading". See: WebPlatformForEmbedded/WPEWebKit#1594 This patch keeps the default behaviour of changing the NetworkState to "Loading", except in the case of a delayed load (the case triggered by preload="none"), in which it's set to Idle and therefore allowing the full destruction of the video element. Original author: Eugene Mutavchi <[email protected]> * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::load): Reset NetworkState to Idle in case of delayed load. Set to Loading otherwise.
Member
|
Submitted the patch for review upstream as https://bugs.webkit.org/show_bug.cgi?id=305473 / WebKit/WebKit#56561 |
webkit-commit-queue
pushed a commit
to eocanha/WebKit
that referenced
this pull request
Jan 14, 2026
https://bugs.webkit.org/show_bug.cgi?id=305473 Reviewed by Xabier Rodriguez-Calvar. Sometimes applications create a <video> tag with 'preload="none"' and then remove the element from the DOM without ever starting playback. This results in the video element being leaked, because HTMLMediaElement::virtualHasPendingActivity() retains the element while its network state is still "Loading". See: WebPlatformForEmbedded/WPEWebKit#1594 This patch keeps the default behaviour of changing the NetworkState to "Loading", except in the case of a delayed load (the case triggered by preload="none"), in which it's set to Idle and therefore allowing the full destruction of the video element. Original author: Eugene Mutavchi <[email protected]> * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::load): Reset NetworkState to Idle in case of delayed load. Set to Loading otherwise. Canonical link: https://commits.webkit.org/305578@main
eocanha
pushed a commit
that referenced
this pull request
Jan 14, 2026
https://bugs.webkit.org/show_bug.cgi?id=305473 Reviewed by Xabier Rodriguez-Calvar. Sometimes applications create a <video> tag with 'preload="none"' and then remove the element from the DOM without ever starting playback. This results in the video element being leaked, because HTMLMediaElement::virtualHasPendingActivity() retains the element while its network state is still "Loading". See: #1594 This patch keeps the default behaviour of changing the NetworkState to "Loading", except in the case of a delayed load (the case triggered by preload="none"), in which it's set to Idle and therefore allowing the full destruction of the video element. Original author: Eugene Mutavchi <[email protected]> * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::load): Reset NetworkState to Idle in case of delayed load. Set to Loading otherwise. Canonical link: https://commits.webkit.org/305578@main
Member
|
Patch landed upstream as WebKit/WebKit@67cc2de and backported to wpe-2.46 as 4c72cef. Closing PR. |
eocanha
pushed a commit
that referenced
this pull request
Jan 16, 2026
https://bugs.webkit.org/show_bug.cgi?id=305473 Reviewed by Xabier Rodriguez-Calvar. Sometimes applications create a <video> tag with 'preload="none"' and then remove the element from the DOM without ever starting playback. This results in the video element being leaked, because HTMLMediaElement::virtualHasPendingActivity() retains the element while its network state is still "Loading". See: #1594 This patch keeps the default behaviour of changing the NetworkState to "Loading", except in the case of a delayed load (the case triggered by preload="none"), in which it's set to Idle and therefore allowing the full destruction of the video element. Original author: Eugene Mutavchi <[email protected]> * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::load): Reset NetworkState to Idle in case of delayed load. Set to Loading otherwise. Canonical link: https://commits.webkit.org/305578@main
Member
|
Patch proactively backported it to wpe-2.38 as a087bcd (See: #1580 (comment)) |
marcin-mielczarczyk-red
pushed a commit
to LibertyGlobal/WPEWebKit
that referenced
this pull request
Jan 16, 2026
https://bugs.webkit.org/show_bug.cgi?id=305473 Reviewed by Xabier Rodriguez-Calvar. Sometimes applications create a <video> tag with 'preload="none"' and then remove the element from the DOM without ever starting playback. This results in the video element being leaked, because HTMLMediaElement::virtualHasPendingActivity() retains the element while its network state is still "Loading". See: WebPlatformForEmbedded#1594 This patch keeps the default behaviour of changing the NetworkState to "Loading", except in the case of a delayed load (the case triggered by preload="none"), in which it's set to Idle and therefore allowing the full destruction of the video element. Original author: Eugene Mutavchi <[email protected]> * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::load): Reset NetworkState to Idle in case of delayed load. Set to Loading otherwise. Canonical link: https://commits.webkit.org/305578@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes applications create a
<video>tag withpreload="none"and then remove the element from the DOM without ever starting playback. This results in the video element being leaked, because HTMLMediaElement::virtualHasPendingActivity() retains the element while its network state is still "Loading".