Test wasip3, without coop threads, with LLVM 23 in CI - #853
Merged
Conversation
* Fix an issue where the wrong compiler-rt was used. This was keyed on coop threads when it should be keyed on the ABI of the wasip3 target. This additionally required moving ABI detection up in CMake. * Tweak the check-symbols logic because now wasip3 has pretty different symbols depending on LLVM 22/23, and it needs to pass on both. * Adjust `__init_tls.c`'s fetching of the stack pointer to use the ABI in question rather than coop threads to determine how to get the stack pointer. * Don't build shared tests for wasip3 with the libcall ABI as that's what's broken, not just coop threads.
dicej
approved these changes
Jul 23, 2026
alexcrichton
enabled auto-merge (squash)
July 23, 2026 22:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue where the wrong compiler-rt was used. This was keyed on coop threads when it should be keyed on the ABI of the wasip3 target. This additionally required moving ABI detection up in CMake.
Tweak the check-symbols logic because now wasip3 has pretty different symbols depending on LLVM 22/23, and it needs to pass on both.
Adjust
__init_tls.c's fetching of the stack pointer to use the ABI in question rather than coop threads to determine how to get the stack pointer.Don't build shared tests for wasip3 with the libcall ABI as that's what's broken, not just coop threads.