Implement UDP send/receive timeouts - #852
Merged
Merged
Conversation
Needed for the Rust standard library's test suite and an otherwise open gap in the implementation in wasi-libc.
alexcrichton
force-pushed
the
udp-timeouts
branch
from
July 23, 2026 04:20
f42bdc9 to
6d2d148
Compare
dicej
approved these changes
Jul 23, 2026
| add_wasilibc_test(pipe_atomic_write.c) | ||
| add_wasilibc_test(pipe_zero_len.c) | ||
| add_wasilibc_test(pipe_espipe.c) | ||
| if (NOT TEST_WITH_V8) |
Collaborator
There was a problem hiding this comment.
What's the reason for this guard?
Collaborator
Author
There was a problem hiding this comment.
The pipe_espipe.c test needs networking with the latest wasmtime (socket creation needs to be enabled) and when doing so it passes arguments to the test (e.g. -Sinherit-network) which the v8 wrapper in this repo doesn't support. I didn't want to deal with that so I just ignored the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for the Rust standard library's test suite and an otherwise open gap in the implementation in wasi-libc.