Repository navigation
Update to wasi-sdk-34.0-rc.2 - #849
Merged
Merged
Conversation
The `--export-table` argument is no longer needed and the type of `__init_tls_base` needed adjusting.
dicej
approved these changes
Jul 22, 2026
alexcrichton
added a commit
that referenced
this pull request
Jul 22, 2026
This commit is the culmination of many previous PRs and changes to make Python able to run all of its tests in wasi-libc's CI with the `wasm32-wasip3` target with coop threads enabled. This notably means that Python is able to run all of its tests with threads, socket, you name it. This is a much larger portion of tests covered than the `wasm32-wasip2` target, for example, because threads are enabled. This naturally needed to adjust the Python source itself (the patch in this repository). A number of tests still need manual skips for WASI or more filtered conditions for when to run. For example wasi-libc still doesn't provide anything related to signals and some tests in Python assume the presence of signals. The goal here though is to, ideally, ignore pretty few tests in the grand scheme of things. I'll also note that there are some tests in Python which require preemptive scheduling. They'll hang or fail with coop threads, and they've been annotated as such. And, finally, there's a few edge-case tests that require WASI workarounds for various I/O behavior and WASI behavior. For example `close` can block, unlike other platforms. Additionally the precise behavior of syscalls may sometimes require more turns of the event loop, things like that. I don't think that the Python patch here is upstreamable as-is, but my hope is that this is at least a basis by which something could eventually be upstreamed. > ~~**Note**: this is temporarily stacked on #849~~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--export-tableargument is no longer needed and the type of__init_tls_baseneeded adjusting.