Make cont.new a constant expression#148
Open
tlively wants to merge 1 commit into
Open
Conversation
Document this in Explainer.md, update the interpreter, and add tests. Remove a runtime type check during global allocation that incorrectly fails for globals holding continuations because continuations do not contain runtime type information. Closes #145.
rossberg
reviewed
May 11, 2026
|
|
||
| let alloc (GlobalT (_mut, t) as ty) v = | ||
| assert Free.((val_type t).types = Set.empty); | ||
| if not (Match.match_val_type [] (type_of_value v) t) then raise Type; |
Member
There was a problem hiding this comment.
There is a similar check in Table.store, which you'll also need to remove. (Would also be good to have tests for putting conts in tables.)
Member
Author
There was a problem hiding this comment.
Sounds good. I'll do that in a separate PR if that's ok.
Member
There was a problem hiding this comment.
You mean the test? Sure, that's fine by me. I'd do the change here, though, to leave it in consistent state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document this in Explainer.md, update the interpreter, and add tests. Remove a runtime type check during global allocation that incorrectly fails for globals holding continuations because continuations do not contain runtime type information.
Closes #145.