Add more string edge case tests#632
Open
friendlymatthew wants to merge 1 commit intoWebAssembly:mainfrom
Open
Conversation
friendlymatthew
force-pushed
the
friendlymatthew/more-string-coverage
branch
from
ce604a9 to
adfc5bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I was browsing through the test suite and noticed a comment in
strings.wastabout more coveragecomponent-model/test/values/strings.wast
Line 18 in c5d7283
I wasn't sure if it was referring to more encoding variations or general coverage, but the file only had 3 assertions so I added a few edge cases for string lifting
I validated this against my own component model implementation