SimplifyGlobals: Do not assume the effect of reading/writing globals implies global.get/set#8433
Merged
kripken merged 5 commits intoWebAssembly:mainfrom Mar 11, 2026
Merged
SimplifyGlobals: Do not assume the effect of reading/writing globals implies global.get/set#8433kripken merged 5 commits intoWebAssembly:mainfrom
kripken merged 5 commits intoWebAssembly:mainfrom
Conversation
tlively
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pass counts global.get/sets carefully, to figure out when all gets and
sets are accounted for in the "reads only to write" pattern. However, it
could miscount due to function effects: we could find the effect of a read/
write without an actual global.get/set, if we had a call to a function with
such contents, and we computed global effects for it.