Add support for (either ...) in wast#8421
Merged
stevenfontanella merged 2 commits intomainfrom Mar 12, 2026
Merged
Conversation
stevenfontanella
force-pushed
the
either2
branch
4 times, most recently
from
c7fcea9 to
d7c1324
Compare
stevenfontanella
changed the title
tlively
reviewed
Mar 5, 2026
Comment on lines
+382
to
+383
| if (!val.type.isRef() || | ||
| !HeapType::isSubType(val.type.getHeapType(), ref->type)) { |
Member
There was a problem hiding this comment.
We should probably check that the value is not null here, too.
Member
Author
There was a problem hiding this comment.
This was part of the existing code, I'll send a new PR for this with a test if that sounds good
stevenfontanella
force-pushed
the
either2
branch
from
d7c1324 to
5c8da70
Compare
stevenfontanella
force-pushed
the
either2
branch
2 times, most recently
from
c3a0d59 to
6b50f74
Compare
Member
Author
|
Force-pushed to rebase onto #8434, should be good to go now. |
tlively
reviewed
Mar 11, 2026
stevenfontanella
force-pushed
the
either2
branch
2 times, most recently
from
876b215 to
02b81c7
Compare
stevenfontanella
added a commit
that referenced
this pull request
Mar 12, 2026
For use in #8421. Previously LaneResults was only used if the expected v128 constant contained NaN patterns, which meant that we lose the shape information (otherwise they were stored/matched as a normal v128 Literal). Change the parser to always use LaneResult so that we keep the shape information and can output exactly which lane doesn't match during test failures. Error message before: ``` expected i32x4 0x56485649 0x56485648 0x56485648 0x56485648, got i32x4 0x56485648 0x56485648 0x56485648 0x56485648 ``` Error message after: ``` expected 22089, got 22088 at lane 0 ``` Part of #8261 and #8315.
Fixes after rebasing
stevenfontanella
force-pushed
the
either2
branch
from
02b81c7 to
f588f47
Compare
tlively
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example failure:
Example failure with SIMD from
relaxed_min_max.wast:Part of #8261 and #8315. Fixes
i16x8_relaxed_q15mulr_s.wast,i8x16_relaxed_swizzle.wast,relaxed_madd_nmadd.wastspec tests, and partially fixesrelaxed_dot_product.wast,relaxed_laneselect.wast,relaxed_min_max.wast, andthreads/thread.wast.