fix: empty login modal in external wallet only mode#2348
Merged
chaitanyapotti merged 6 commits intov10from Feb 3, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
what's the context of this pr? |
Member
Author
Bug: When initializing Web3Auth with AUTH connector hidden (external wallets only mode), the modal appears empty on first open. Close and reopen → wallets appear. Example: Screen.Recording.2026-01-26.at.19.21.12.mov |
Member
Author
|
Original condition:
Problem:
New condition:
Why it works:
|
Contributor
|
@cursor review |
Member
|
why are we hiding the success screen for external wallets? |
ff132f6 to
84b3771
Compare
chaitanyapotti
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Jira Link:
NA
Description
This PR changes:
How has this been tested?
Screenshots (if appropriate):
Before:
https://github.com/user-attachments/assets/af88d9ef-dfa2-4f57-8634-884eb4c9c287
After:
https://github.com/user-attachments/assets/ab9abf04-8378-469f-9682-230c9b88c984
Types of changes
Checklist:
Note
Medium Risk
Changes modal page-rendering conditions and demo configuration for external-wallet-only flows; regressions could affect which screens/buttons render for different login configurations.
Overview
Fixes the empty modal issue when only external wallets are available by updating
Root.tsxto render theConnectWalletscreen even whenshowExternalWalletPageis true but the UI is effectively external-wallet-only.Updates the Vue demo to support an
externalWalletOnlysetting end-to-end (form toggle, persisted state, typed config) that hides theauthconnector on the modal and setsuiConfig.primaryButtontoexternalLoginwhen enabled.Written by Cursor Bugbot for commit e5d16b3. This will update automatically on new commits. Configure here.