Refactor: W3APD-5238 - migrate from @solana/web3.js to @solana/kit#2347
Open
tanguyenvn wants to merge 6 commits intomasterfrom
Open
Refactor: W3APD-5238 - migrate from @solana/web3.js to @solana/kit#2347tanguyenvn wants to merge 6 commits intomasterfrom
tanguyenvn wants to merge 6 commits intomasterfrom
Conversation
- Replace Connection with RPC client from @solana/kit - Update transaction types to use @solana/kit's Transaction - Remove @toruslabs/bs58 in favor of @solana/kit's base58 utilities - Update demo app to use new Solana utilities BREAKING CHANGE: connection property renamed to rpc, transaction types now expect compiled Transaction from @solana/kit
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
8c378ae to
4c2564b
Compare
tanguyenvn
commented
Jan 27, 2026
| } | ||
| }; | ||
|
|
||
| export const signAndSendTransaction = async (provider: IProvider, uiConsole: any) => { |
Contributor
Author
There was a problem hiding this comment.
clean up as these functions are not used
tanguyenvn
commented
Jan 27, 2026
| import { generateSolTransferInstruction, generateVersionedTransaction } from "../utils/solana"; | ||
|
|
||
| // EVM | ||
| export const walletSignPersonalMessage = async ( |
Contributor
Author
There was a problem hiding this comment.
clean up as these functions are not used
Contributor
Author
|
@cursor review |
Contributor
Author
|
bugbot run |
Member
|
Is there a way to remove all our custom provider wrappers and use the custom signers? |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
fde1489 to
c635ce3
Compare
13d7c14 to
c14c849
Compare
- Remove base58 test code and console.log from App.vue - Remove unused generateKeyPair/generateKeyPairSigner imports from AppDashboard.vue - Bump @solana-program/system to ^0.12.0 Made-with: Cursor
c14c849 to
64b6b97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: connection property renamed to rpc, transaction types now expect compiled Transaction from @solana/kit
Motivation and Context
Jira Link:
Description
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Note
Medium Risk
Medium risk because it changes Solana transaction construction/signing inputs and the Solana wallet composable API (
connection→rpc), which can break downstream integrations at runtime if any callers still rely on@solana/web3.jstypes or the old fields.Overview
Migrates Solana integration to
@solana/kitacross the Vue demo and Web3Auth Solana hooks/composables, replacing@solana/web3.jsConnectionusage with a@solana/kitrpcclient andTransactiontype.Updates the demo’s Solana actions to build transfer instructions and compile legacy/versioned transactions via new
utils/solanahelpers, and simplifiessolHandlersto fetch balances directly viarpc.getBalance(...). Removes the demowalletServiceHandlersfile and updates dependencies/lockfile (adds@solana/kit+@solana-program/system, bumps@web3auth/*workspace versions and wagmi/viem-related deps).Written by Cursor Bugbot for commit 64b6b97. This will update automatically on new commits. Configure here.