-
Notifications
You must be signed in to change notification settings - Fork 30
TTD code coverage time range filter #962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Hi @NicoleFaye , thanks a lot for the PR. This looks like a nice addition, I will review it when I can |
|
upon further examination. it seems like it might be more appropriate to implement a call to instead of manually filtering time positions on a generic memory query. I can implement a change in logic, but wanted to add this comment before then. My main concern with this possible change would be it's not generic enough to work with time travel debuggers other than windbg, I haven't looked too deeply at how the adapters work. or if this coverage analysis is specific to windbg. |
|
Please also create a separate issue to track the other enhancements made in this PR, which helps us better keep track of things! |

Added time range filter for ttd code coverage analysis.
Adjusted code coverage highlight alpha 1/4 -> 2/3
Fixed info log being incorrectly written to error stream for saving cached analysis results.
Added gitignore entries for windows build related artifacts
First time contributing to the repo. I vaguely understand there is an agreement i may need to sign if the code is accepted.
Let me know if there is anything i can do to improve this PR for future reference/contribution.
fixes #960