Skip to content

fix: dangling audio elements when user ends the call #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adrivelasco wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −4
Open

fix: dangling audio elements when user ends the call #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions vapi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,11 +257,22 @@ async function buildAudioPlayer(
return player;
}

function teardownAudioPlayer(player: HTMLAudioElement) {
player.srcObject = null;
player.remove();
}

function destroyAudioPlayer(participantId: string) {
const player = document.querySelector(
`audio[data-participant-id="${participantId}"]`,
);
player?.remove();
const player = document.querySelector<HTMLAudioElement>(`audio[data-participant-id="${participantId}"]`);
if (player) {
teardownAudioPlayer(player)
};
}

function destroyAllAudioPlayers() {
document
.querySelectorAll<HTMLAudioElement>('audio[data-participant-id]')
.forEach(teardownAudioPlayer);
}

function subscribeToTracks(
Expand Down Expand Up @@ -346,6 +357,7 @@ export default class Vapi extends VapiEventEmitter {
await this.call.destroy();
this.call = null;
}
destroyAllAudioPlayers();
this.speakingTimeout = null;
}

Expand Down Expand Up @@ -973,6 +985,7 @@ export default class Vapi extends VapiEventEmitter {
await this.call.destroy();
this.call = null;
}
destroyAllAudioPlayers();
this.speakingTimeout = null;
}

Expand Down