Skip to content

Conversation

@scop
Copy link
Member

@scop scop commented Sep 17, 2025

Base automatically changed from chore/workflow-token-perms to main September 19, 2025 08:54
@scop scop force-pushed the chore/trusted-pypi-publishing branch from 8614531 to dc6a48c Compare September 24, 2025 10:49
path: dist/
publish:
runs-on: ubuntu-latest
needs: build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include here: needs: [lint, test, build] ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinions, might not be a bad idea, but just noting that those dependencies did not exist before this change either -- deploy did not depend on build (which is now renamed to more descriptive test), and nothing had a dependency on lint. publish's dependency on build as introduced here is a hard one now, though.

@scop scop marked this pull request as ready for review September 24, 2025 12:28
@scop scop requested a review from a team as a code owner September 24, 2025 12:28
@scop scop force-pushed the chore/trusted-pypi-publishing branch from dc6a48c to 74f9bc7 Compare September 24, 2025 12:35
@paketeserrano paketeserrano merged commit 522d70b into main Sep 25, 2025
21 of 23 checks passed
@paketeserrano paketeserrano deleted the chore/trusted-pypi-publishing branch September 25, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants