[pull] master from SchemaStore:master - #625
Merged
Merged
Conversation
* AI(gpt-5.6-sol): Add action output dispatch regression tests
Each fixture was added individually on top of master, then tested with:
node ./cli.js check --schema-name=github-action.json
`outputs-empty.json`:
>> Failed to validate file "src/test/github-action/outputs-empty.json" against schema file "./src/schemas/json/github-action.json"
>> Showing first error out of 1 total error(s)
{
instancePath: '/outputs',
schemaPath: '#/properties/outputs/oneOf',
keyword: 'oneOf',
params: { passingSchemas: [ 0, 1 ] },
message: 'must match exactly one schema in oneOf'
}
`output-id-runs.json`:
>> Failed to validate file "src/test/github-action/output-id-runs.json" against schema file "./src/schemas/json/github-action.json"
>> Showing first error out of 3 total error(s)
{
instancePath: '/outputs',
schemaPath: '#/definitions/outputs-composite/dependencies/runs/required',
keyword: 'required',
params: { missingProperty: 'using' },
message: "must have required property 'using'"
}
`javascript-output-with-value.json`:
>> Schema validation succeeded for test file "./src/negative_test/github-action/javascript-output-with-value.json", but was supposed to fail
>> For schema "./src/schemas/json/github-action.json"
`composite-output-missing-value.json`:
>> Schema validation succeeded for test file "./src/negative_test/github-action/composite-output-missing-value.json", but was supposed to fail
>> For schema "./src/schemas/json/github-action.json"
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* AI(gpt-5.6-sol): Restore action output schema dispatch
The strict-validation rewrite moved runtime-dependent output selection into
`dependencies` nested under each output definition. At that level, `runs`
means an output identifier rather than the top-level action runtime, so the
schema cannot distinguish composite outputs from JavaScript or Docker outputs.
Restore top-level `if` / `then` / `else` dispatch based on `runs.using`. Keep
the placeholder `outputs` property required by draft-07
`additionalProperties: false`, and declare the nested `runs` condition as an
object so AJV strict type validation still passes.
This makes empty output maps and output IDs named `runs` valid again, rejects
JavaScript outputs containing composite-only `value`, and requires `value` for
composite outputs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Strict validation made `workflow_call` object-only even though GitHub accepts the empty YAML trigger form. Model it using the existing object-or-null event style and cover the shorthand in the null-event fixture. Fixes #6303 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )