make @types/openui5 a dev dependency

[nkappler]

when installing the webcomponents, they pull in @types/openui5 as a dependency, although it should be a dev dependency.
This leads to conflicts in our repository, since we use patch-package to patch incorrect types in that package, but additional copy added by webcomponents is overwriting them again...

fix #13459

[cla-assistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[nnaydenow]

Hi @pskelin,

could you check here?

[nkappler]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I was trying to sign the CLA but the link seems to be broken

[pskelin]

@nkappler this was specifically added as a dependency with #6346
before that, there was an error that the types are not portable - they appear in the .d.ts files that we ship (we extend them in some places in the localization package), and if the types are not a dependency, consumers will get errors or have to install the types themselves.

can you check why patch package fails? it should not be an issue if multiple packages in your repo point have the same dependency, patch package usually runs after npm install so it should still apply the patch regardless of the way the dependency came.

[nkappler]

@pskelin patch-package runs successful, the issue is that we have a duplicate install of the openui5 types and the non-patched version installed as a dependency by the webcomponents takes precedence.
We might be able to fix this with an npm override, although we have seen some issues there too, but I still think that a library shouldn't load type declarations as a dependency, especially not the UI5 ones as the still contain a lot of errors and imprecisions.
Maybe it could be a peer dependency? https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependencies
As I understand it, it would ensure that the type declarations would still be installed if not present, but there should be more flexible options on resolving the dependency...

[nkappler]

@pskelin also, what's the reason for using @types/openui5 instead of @sapui5/types? It's the same package, but the latter uses the same versioning scheme as UI5 itself, making it much easier to choose the correct version (it's the same version every time). @types/openui5 only get's a version bump if there are actual changes to it.