test(install): stop downloading a release the advice test does not need - #1232
Merged
Conversation
The retry named a path that does not exist, so it parsed, passed the destination check, created the folder and downloaded the release -- 10.27s in the profile, and a network dependency the test's own comment denied having. What the assertion needs is proof the parser accepted the form, and reaching the destination check is that proof: it is the stage after parsing. Point the retry at a second blocked path instead. 10.27s -> 1.58s. Closes #1231
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #1231
test_the_recovery_advice_names_a_form_the_parser_acceptssays it needs no network. Its first run does not; its retry named a non-existent path, so it parsed, passed the destination check and downloaded the release — 10.27s, fifth-slowest test in the suite, and a network dependency it should not have.💡 Changes
-dstill fails it