fix(install): stop advising a -d flag that does not exist - #1222
Merged
Conversation
All three destination errors ended with "Choose another destination with -d". install.sh parses positional arguments only, so the one message whose job is to tell the reader how to recover pointed at a form the parser rejects with "Invalid arguments". The existing tests asserted the diagnosis line and stopped there, so the invented flag was never executed. The new test runs the suggested form instead of string-matching it, and checks the advice on the run that actually prints it -- a flag-shaped argument dies in the parser first, so asserting there compares against nothing and passes for free. That vacuous version was written, caught by mutating the message back, and replaced. Closes #1221
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #1221
All three destination errors in
install.shended withChoose another destination with -d. The script parses positional arguments only, so following that advice returnsInvalid arguments— the one message whose job is to tell the reader how to recover pointed at a form the parser rejects.💡 Changes