docs(changelog): correct the bootstrap mechanism and merge a split entry - #1184
Merged
Conversation
The special-builtin claim was corrected in the code comments and on the issues (#1183) but not here, which is the copy users actually read: a syntax error makes source return non-zero and the shell dies because set -e is active, while a bare exit ends it regardless. Also folds two entries into one. Surviving a vanished scratch directory and reporting it are one behaviour from a user's side; they were split only because the reporting half was added after the survival half.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
#1183 corrected a wrong claim in the code comments and on #1179/#1181 — that
sourceis a POSIX special builtin and a syntax error therefore ends the shell.The CHANGELOG still carried it, and that is the copy users actually read.
Measured: a syntax error makes
sourcereturn non-zero and the shell diesbecause
set -eis active there; a bareexitends it regardless.💡 Changes