fix(cli): guard every bootstrap load, not just the env-var one - #1182
Merged
Conversation
#1180 covered the BASHUNIT_BOOTSTRAP path. The --env/--boot flag sources its file at other call sites, which kept the same hole: a syntax error there still gave exit 0 with no tests and no summary, and bench --boot behaved the same. The flag path validated that the file exists (#875) but could not check that sourcing succeeded -- source is a special builtin, so the shell ends at that point. Apply the same marker to the remaining sites. Audited afterwards: 5 of 5 bootstrap source sites carry the marker. Closes #1181
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #1181
#1180 fixed the
BASHUNIT_BOOTSTRAPpath. The--env/--bootflag sourcesits file at different call sites and kept the same hole:
No tests, no summary, exit 0 — and
bench --bootthe same. The flag pathvalidated that the file exists (#875) but cannot check that sourcing
succeeded:
sourceis a special builtin, so the shell ends right there.💡 Changes
test.sh,bench.shandsubcommands.shsourcesites carry the marker--envfile still loads and its values reach the run