fix(cli): reject a report path that is a directory - #1178
Merged
Conversation
A directory satisfies both -e and -w, so it passed the writability check and the run continued to the writer, which failed with a raw bash message naming a bashunit source file -- and still exited 0. The report was never written and CI stayed green, so a job publishing it found no file and nothing red to explain it. A missing parent directory was already caught, which is what made the gap easy to miss. Reject it in both writability checks, naming the actual mistake: 'cannot be written' sends the reader to permissions, and a directory is almost always a forgotten filename. Closes #1177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #1177
--report-junit build/(filename forgotten) passes validation, because adirectory satisfies both
-eand-w. The run then reaches the writer:and exits 0 — no report written, a message naming a bashunit source file
rather than the user's mistake, and CI green. A job publishing that report
finds no file and nothing red to explain it.
A missing parent directory was already caught properly, which is what made
this gap easy to miss.
💡 Changes
is a directory, not a file— "cannot be written" would send the reader to permissions--report-junit,--report-json,--report-html,--report-md,--log-junitand thebenchequivalents; normal paths still write