Removed parse-email-address package (it moved to monorepo) #342
+6
−386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
EvanHahn
added a commit
to TryGhost/Ghost
that referenced
this pull request
Jan 21, 2026
closes https://linear.app/ghost/issue/NY-942/create-and-use-parse-email-address-package-in-core ref #25919 ref TryGhost/framework#342 This creates the `parse-email-address` package (previously reviewed [here][0]--all I did was move it over) and uses it in email normalization, used when sending magic links. This should not change behavior for "normal", lowercase ASCII email addresses. However, it does make several subtler tweaks to the way emails are normalized: - Some totally invalid emails weren't normalized. Before: if `req.body.email` wasn't a string or lacked an `@`, no normalization would occur. The system would then attempt to send an email that'd almost certainly fail. After: these throw a "bad request" error. - Invalid emails with multiple `@` signs were considered valid. Before: `foo@bar@example.com` was accepted. After: it is not accepted and throws a "bad request" error. - Long emails are now considered invalid. Before: the only limit on email length was that of the request body. After: the whole email is limited to 986 octets and the domain is limited to 253 octets (per SMTP). Domain labels are limited to 63 octets (per DNS). - Domains are now lowercased. Before: `FOO@Example.COM` was normalized to `FOO@Example.COM`. After: `FOO@Example.COM` is normalized to `FOO@example.com`. [0]: TryGhost/framework#340
EvanHahn
force-pushed
the
remove-parse-email-address-package
branch
from
b4505b3 to
2d5bcd9
Compare
EvanHahn
added a commit
to TryGhost/Ghost
that referenced
this pull request
Jan 21, 2026
closes https://linear.app/ghost/issue/NY-942/create-and-use-parse-email-address-package-in-core ref #25919 ref TryGhost/framework#342 This creates the `parse-email-address` package (previously reviewed [here][0]--all I did was move it over) and uses it in email normalization, used when sending magic links. This should not change behavior for "normal", lowercase ASCII email addresses. However, it does make several subtler tweaks to the way emails are normalized: - Some totally invalid emails weren't normalized. Before: if `req.body.email` wasn't a string or lacked an `@`, no normalization would occur. The system would then attempt to send an email that'd almost certainly fail. After: these throw a "bad request" error. - Invalid emails with multiple `@` signs were considered valid. Before: `foo@bar@example.com` was accepted. After: it is not accepted and throws a "bad request" error. - Long emails are now considered invalid. Before: the only limit on email length was that of the request body. After: the whole email is limited to 986 octets and the domain is limited to 253 octets (per SMTP). Domain labels are limited to 63 octets (per DNS). - Domains are now lowercased. Before: `FOO@Example.COM` was normalized to `FOO@Example.COM`. After: `FOO@Example.COM` is normalized to `FOO@example.com`. [0]: TryGhost/framework#340
EvanHahn
added a commit
to TryGhost/Ghost
that referenced
this pull request
Jan 21, 2026
closes https://linear.app/ghost/issue/NY-942/create-and-use-parse-email-address-package-in-core ref #25919 ref TryGhost/framework#342 This creates the `parse-email-address` package (previously reviewed [here][0]--all I did was move it over) and uses it in email normalization, used when sending magic links. This should not change behavior for "normal", lowercase ASCII email addresses. However, it does make several subtler tweaks to the way emails are normalized: - Some totally invalid emails weren't normalized. Before: if `req.body.email` wasn't a string or lacked an `@`, no normalization would occur. The system would then attempt to send an email that'd almost certainly fail. After: these throw a "bad request" error. - Invalid emails with multiple `@` signs were considered valid. Before: `foo@bar@example.com` was accepted. After: it is not accepted and throws a "bad request" error. - Long emails are now considered invalid. Before: the only limit on email length was that of the request body. After: the whole email is limited to 986 octets and the domain is limited to 253 octets (per SMTP). Domain labels are limited to 63 octets (per DNS). - Domains are now lowercased. Before: `FOO@Example.COM` was normalized to `FOO@Example.COM`. After: `FOO@Example.COM` is normalized to `FOO@example.com`. [0]: TryGhost/framework#340
ref a5384b4 ref TryGhost/Ghost#25920 `@tryghost/parse-email-address` has been moved to the main Ghost repo in <TryGhost/Ghost#25920>. This reverts commit a5384b4.
EvanHahn
force-pushed
the
remove-parse-email-address-package
branch
from
2d5bcd9 to
1e0f31e
Compare
EvanHahn
added a commit
to TryGhost/Ghost
that referenced
this pull request
Jan 22, 2026
closes https://linear.app/ghost/issue/NY-942/create-and-use-parse-email-address-package-in-core ref #25919 ref TryGhost/framework#342 This creates the `parse-email-address` package (previously reviewed [here][0]--all I did was move it over) and uses it in email normalization, used when sending magic links. This should not change behavior for "normal", lowercase ASCII email addresses. However, it does make several subtler tweaks to the way emails are normalized: - Some totally invalid emails weren't normalized. Before: if `req.body.email` wasn't a string or lacked an `@`, no normalization would occur. The system would then attempt to send an email that'd almost certainly fail. After: these throw a "bad request" error. - Invalid emails with multiple `@` signs were considered valid. Before: `foo@bar@example.com` was accepted. After: it is not accepted and throws a "bad request" error. - Long emails are now considered invalid. Before: the only limit on email length was that of the request body. After: the whole email is limited to 986 octets and the domain is limited to 253 octets (per SMTP). Domain labels are limited to 63 octets (per DNS). - Domains are now lowercased. Before: `FOO@Example.COM` was normalized to `FOO@Example.COM`. After: `FOO@Example.COM` is normalized to `FOO@example.com`. [0]: TryGhost/framework#340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref a5384b4
ref TryGhost/Ghost#25920
@tryghost/parse-email-addresswill be moved to the main Ghost repo in TryGhost/Ghost#25920.This reverts commit a5384b4.