Allow multiple [CleanUtility(...)] annotations per class#88
Allow multiple [CleanUtility(...)] annotations per class#88TonyTroeff wants to merge 5 commits intomainfrom
[CleanUtility(...)] annotations per class#88Conversation
TonyTroeff
added
feature
|
There was a problem hiding this comment.
Pull request overview
This PR enables multiple [CleanUtility(...)] annotations on the same class by changing the AllowMultiple parameter from false to true in the CleanUtilityAttribute. The existing code in CleanTestFramework.cs already supports iteration over multiple attributes, so the change enables a previously disabled capability.
Changes:
- Modified
CleanUtilityAttributeto allow multiple instances per class (AllowMultiple = true) - Renamed local variable from
initializationUtilityAttributestocleanUtilityAttributesfor better consistency with the attribute name
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| TryAtSoftware.CleanTests.Core/Attributes/CleanUtilityAttribute.cs | Updated AttributeUsage to allow multiple annotations per class |
| TryAtSoftware.CleanTests.Core/XUnit/CleanTestFramework.cs | Renamed variable for consistency (functionality already supported multiple attributes) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Replace hardcoded TryAtSoftware/CleanTests#88 with argparse so the reviewer can be pointed at any repository and pull request.
Pull Request Description
This pull request introduces support for allowing multiple
[CleanUtility(...)]annotations on the same class, enhancing the functionality and flexibility of the CleanUtility attribute.Motivation and Context
Previously, it was only possible to use a single
[CleanUtility(...)]annotation per class, which could be limiting for more complex scenarios requiring multiple attributes. This change provides more versatility.Checklist