Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for encrypted SharedPreferences to the SharedPref Manager, allowing developers to view and debug encrypted preference files alongside regular ones. The implementation introduces a more flexible architecture by replacing string-based preference names with a provider pattern.
- Adds encrypted SharedPreferences support with a new button in the sample UI
- Refactors SharedPref Manager to use a provider pattern instead of string names
- Updates minimum SDK version to 23 to support encrypted preferences dependency
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sample/src/main/res/values/strings.xml | Adds string resource for encrypted SharedPref button |
| sample/src/main/res/layout/main_fragment.xml | Adds new button for encrypted SharedPref manager and adjusts layout constraints |
| sample/src/main/java/com/trendyol/android/devtools/ui/main/MainFragment.kt | Implements encrypted SharedPreferences creation and button click handling |
| sample/src/main/java/com/trendyol/android/devtools/App.kt | Minor import reordering and whitespace cleanup |
| sample/build.gradle.kts | Updates minSdk to 23 and adds encrypted preferences dependency |
| libraries/sharedpref-manager/src/main/java/com/trendyol/android/devtools/sharedprefmanager/di/SharedPrefUseCaseContainer.kt | Refactors to use SharedPreferencesProvider instead of string name |
| libraries/sharedpref-manager/src/main/java/com/trendyol/android/devtools/sharedprefmanager/di/ContextContainer.kt | Introduces SharedPreferencesProvider sealed class and updates container logic |
| libraries/sharedpref-manager/src/main/java/com/trendyol/android/devtools/sharedprefmanager/SharedPrefManager.kt | Adds overloaded show method accepting SharedPreferences instance |
| libraries/sharedpref-manager/build.gradle.kts | Bumps library version to 0.3.0 |
| gradle/libs.versions.toml | Adds encrypted preferences library dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sample/src/main/java/com/trendyol/android/devtools/ui/main/MainFragment.kt
Outdated
Show resolved
Hide resolved
sample/src/main/java/com/trendyol/android/devtools/ui/main/MainFragment.kt
Outdated
Show resolved
Hide resolved
sample/src/main/java/com/trendyol/android/devtools/ui/main/MainFragment.kt
Show resolved
Hide resolved
added 2 commits
August 27, 2025 06:25
bilgehankalkan
approved these changes
Aug 27, 2025
mustafaberkaymutlu
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.