fix(model-bridge): restore native state dict round trips - #1591
Open
mikemikimike wants to merge 1 commit into
Open
fix(model-bridge): restore native state dict round trips#1591mikemikimike wants to merge 1 commit into
mikemikimike wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TransformerBridge.state_dict()round trips through the native/raw model.strict=Trueinstead of silently downgrading strict loads.Fixes #1587
Validation
PYTHONUTF8=1 uv run pytest tests/unit -m "not slow" -n 4 -q— 5,165 passed, 57 skipped, 10 xfailedPYTHONUTF8=1 uv run pytest tests/unit/model_bridge/test_boot_native.py -q— 28 passeduv run mypy .— passed, 421 source filesuv run pycln --check ...— passeduv run isort --check-only ...— passeduv run black --check ...— passedgit diff --check— passedThe focused
tests/integration/model_bridgerun was attempted locally but exceeded the 15-minute execution limit without producing a test assertion failure; the unit suite and targeted regression suite completed successfully.